-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demangle support using external rustfilt
tool
#2
Conversation
Rebased and re-tested: Symbols that previously looked like This does emit a warning about not having been able to run the demangler even when there are no Rust symbols, but then I don't know how to reliably recognize them, it's just a warning, and it's not like there's certainty that there are no surprise Rust modules in RIOT any more ;-) Please review. |
rustfix
toolrustfilt
tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally (or rather with BUILD_IN_DOCKER=1
) with examples/rust-gcoap
and can confirm this to work nicely.
All rust symbols are grouped under "unspecified", but that was already the case before so out of scope for this PR, I'd say.
Just a minor suggestion below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, the commit message should be changed with s/rustfix/rustfilt/
Thanks for checking, fixed. |
Applied the commit message suggestion
This PR adds support for an external demangler: If
rustfilt
is present, symbol names are shown in a demangled way. This should cover not only Rust but also C++ symbols.This is moving haukepetersen#12 in here; marked as a draft as I'll have yet to review whether this is still all current.