Feature/rushfiles #343
Open
Feature/rushfiles #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tsukaeru.net is a partner and a reseller of RushFiles in Japan under the brand FileBako.
- add company name to share name - sort shares by name - change size of the icon - various other small issues
Makinami
force-pushed
the
feature/rushfiles
branch
from
3d34cb5 to
10bb0f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending again the PR for adding RushFiles storage addon. The only changes from the previous (#295 ) is that I have cleaned up the git log a bit by rebasing and had to recreate translation file (with commands from README).
I'm copy-pasting the content of previous PR.
My name is Wiktor Klonowski and I am sending this pull request on behalf of Tsukaeru.net.
Purpose
As discussed via email and video conference in October last year, we would like to add to GakuNin RDM a support for our file storage solution: RushFIles (FileBako in Japan). This PR (and corresponding PR in waterbutler repository: RCOSDP/RDM-waterbutler#36) implements an addon for this integration.
At the moment, addon integrates only with user panel. Integration with organization's administrator control panel might come in the future, but is out of scope of this PR.
Changes
Add support for a new file storage service called RushFiles (FileBako in Japan).
QA Notes
Yes, but only the basic addition to the database to support new addon. Although we've had some problems with incompatibility with broken migration chain with wiki addon.
Should be minimal.
No.
Purely additive. It introduces a new addon and it's static files/translations, without modifying any of the base source code.
This PR adds a new addon usable by user. The addon does not provide functionality in admin control panel at the moment, so testing should be done through user's UI.
No direct changes to the API.
Added support for a new file storage.
Impact should be minimal, as we are only loading one more addon.
Please let us know if you need a RushFiles/FileBako account for testing.
Documentation
Depending on whether such list is provided on RCOSDP page, a list of supported file storage solutions might need updating.
The rudimentary documentation for RushFiles API can be found here: https://wiki.rushfiles.com/api . For any questions, you may contact [email protected] .
Side Effects
No known side effects.
Ticket
N/A
Notes
Despite our best effort, we couldn't solve this problem without internal knowledge of the entire system or intrusive changes. Because of this, the addon wasn't tested on the latest version of branch. However, as it does not use deprecated Python 2.7 features and works similarly to other storage addons, I don't believe there will be any problem with running it on Python 3.6. Should there be bugs or if you know how to build and run newest develop branch, please let us know.