fix: migrate Codex references to @agentclientprotocol/codex-acp - #383
Conversation
The @zed-industries package is deprecated (same maintainers, bin name unchanged). Version-gate the migration notice: old and new adapters both report "codex-acp", but only the old one is below 1.0.0.
…-acp Also aligns the agent tables with the Claude row and adds a migration tip for the old package.
Adapters differ in the reported name/version (e.g. the codex-acp package move kept the bin name); surface it in the debug log so update-checker behavior can be verified in the field.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThe PR replaces the deprecated Codex ACP package with ChangesCodex ACP migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
@zed-industries/codex-acpis deprecated on npm ("replaced by @agentclientprotocol/codex-acp" — same maintainer team,codex-acpbin name unchanged). This updates every reference to the successor package:codex-acpbinary)The migration notice needed some care: the adapter kept its bin name across the move, so the reported name alone can't always tell old from new.
DEPRECATED_PACKAGESbecame structuredDEPRECATION_RULESwith anonlyBelow: "1.0.0"version gate for codex (the old package never published 1.x), and the uninstall target is carried separately from the reported name. The Claude rules are behavior-identical. Added offline unit tests for the rules (195 tests total), and a debug log of the connected agent's reported name/version.Related issue
#380 — keeping it open until the fix ships with the release (the docs site deploys from
master).Type of change
Checklist
npm run lintpasses ("Use sentence case for UI text" errors are acceptable for brand names)npm run buildpassesTesting environment
@agentclientprotocol/codex-acp1.1.9) connects with no false noticeScreenshots
N/A
Summary by CodeRabbit
Documentation
Bug Fixes
Tests