chore: translate the leftover Japanese JSDoc comments - #369
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change revises JSDoc for legacy preset-agent keys in ChangesPreset agent documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Two JSDoc lines in
preset-agents.ts(legacySettingsKey/legacyCommandPathKey) still carried a Japanese fragment ("data.json 旧形式 …") from the registry design sketch — the translation of the leading words was missed when the registry landed in #348. Both now readLegacy data.json ….A full sweep for Japanese characters (hiragana, katakana, CJK, full-width punctuation) across
src/,test/,styles.css, config files,docs/sources, and.github/confirmed these two lines were the only remaining occurrences — the codebase is now English-only (README.ja.md is intentionally Japanese and out of scope).Related issue
None.
Type of change
Checklist
npm run lintpasses ("Use sentence case for UI text" warnings are acceptable for brand names)npm run buildpassesTesting environment
Screenshots
N/A
Summary by CodeRabbit