feat: show the plugin icon on agent buttons - #367
Merged
Conversation
📝 WalkthroughWalkthroughThe button block CTA now includes a leading bot icon from ChangesButton block icon
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Agent buttons (the
agent-client-buttonquick-action block) now show the plugin's identity icon — the same lucidebot-message-squareused by the ribbon, chat views, and the Session Manager — to the left of the button text, so a note full of buttons makes it obvious at a glance which ones belong to Agent Client.The change rides entirely on existing pieces: the shared
LucideIconwrapper (Obsidian'ssetIcon, no innerHTML) renders the icon, and the button was alreadyinline-flexwithgap: 8px, so the only CSS added is a 16px svg size rule. The icon color is deliberately unspecified — it inheritsmod-cta's foreground and follows light/dark themes automatically. The icon is fixed (not a fence option): the point is recognizability, and a per-buttonicon:field would work against that; it remains a one-parser-field addition if ever requested.The docs screenshot (
agent-button-block.webp) is refreshed to show the new look; the options table is unchanged (no new option).Related issue
None (UI idea from manual testing).
Type of change
Checklist
npm run lintpasses ("Use sentence case for UI text" warnings are acceptable for brand names)npm run buildpassesTesting environment
Screenshots
Summary by CodeRabbit