style: render custom agent sections like presets - #361
Conversation
The card predates the collapsible sections; summary rows now mark the boundaries, so custom agents render exactly like presets.
A bare-button setting row renders as an empty card in themes that box setting items; naming the row makes it read like every other setting.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe custom-agent settings UI now uses a named and described creation control, renders collapsible agent sections directly in their parent container, and removes obsolete custom-agent and documentation-link hover styling. ChangesCustom agent settings
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Custom agents in the settings tab were still wrapped in a card (background, border, rounded corners) — a leftover from before the collapsible agent sections (#350), when custom agent settings were a flat list and the card was the only thing marking where one agent ended and the next began. Since #350 the summary rows mark those boundaries themselves, so the card had become a double border; the CSS even carried a correction rule (
border-top: noneinside the card) to hide the doubling.renderCustomAgentno longer creates theagent-client-custom-agentwrapper and renders the collapsible section directly, exactly likerenderPresetSettings. Both card CSS rules (the card itself and the border-top correction) are deleted with it — the class is now referenced nowhere (grep-verified). Custom agents render identically to presets: summary rows separated by thin rules.No behavior change: section open/collapse state, the Enabled toggle, and the delete button all live in the summary row and are untouched.
Related issue
None.
Type of change
Checklist
npm run lintpasses ("Use sentence case for UI text" errors are acceptable for brand names)npm run buildpassesTesting environment
Screenshots
Summary by CodeRabbit