Skip to content

fix(eslint-plugin): detect node API usage more accurately #7664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: build/v2
Choose a base branch
from

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Jun 9, 2025

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

I enhanced the qwik-eslint-plugin to support two edge cases:

  1. When process is directly used as an init in a VariableDeclarator in AST.

2.When path is used as a property key inside an object.
adding two situations

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Jun 9, 2025

🦋 Changeset detected

Latest commit: 3e304c3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JerryWu1234 JerryWu1234 self-assigned this Jun 9, 2025
Copy link

pkg-pr-new bot commented Jun 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7664
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7664
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7664
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7664

commit: 3e304c3

Copy link
Contributor

github-actions bot commented Jun 9, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 3e304c3

@JerryWu1234 JerryWu1234 marked this pull request as ready for review June 12, 2025 06:55
@JerryWu1234 JerryWu1234 requested a review from a team as a code owner June 12, 2025 06:55
@JerryWu1234 JerryWu1234 moved this from Backlog to Waiting For Review in Qwik Development Jun 12, 2025
@JerryWu1234 JerryWu1234 marked this pull request as draft June 12, 2025 07:17
@JerryWu1234 JerryWu1234 marked this pull request as ready for review June 12, 2025 07:26
@JerryWu1234 JerryWu1234 changed the title Draft: Qwik plugin check Qwik plugin check Jun 12, 2025
@wmertens wmertens changed the title Qwik plugin check fix(eslint-plugin): detect node API usage more accurately Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting For Review
Development

Successfully merging this pull request may close these issues.

2 participants