-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: better materialization error and dev location fix #7551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: build/v2
Are you sure you want to change the base?
Conversation
|
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Great, but actually the location is unreadable without training. Since it's dev mode, can't we log the actual element so that when you hover it in the console you can see it highlighted on the page? |
The problem is qerrors supports only strings. I am thinking if it should be a QError at all, maybe not |
Thanks Michal! reason: we teach about resumability but nobody knows yet what materialization means (and it's yet another term we need to teach about). So I think this will help keeping it simpler for us and for Qwik devs. Plus adding a link to a doc that explains this error in more depth with possible fixes would be nice. |
ee2f893
to
50b11b7
Compare
50b11b7
to
7d38de6
Compare
Throw an error with better description what is failing
example:
This also fixes dev location for CSR rendering