Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core dev): copy optimizer from CI build if dev #7283

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix(core dev): copy optimizer from CI build if dev #7283

merged 2 commits into from
Jan 30, 2025

Conversation

wmertens
Copy link
Member

this makes sure that recent optimizer changes are used when not building the optimizer

@wmertens wmertens requested a review from a team as a code owner January 27, 2025 13:48
@wmertens wmertens enabled auto-merge January 27, 2025 13:48
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 46861fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 30, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7283

npm i https://pkg.pr.new/@builder.io/qwik-city@7283

npm i https://pkg.pr.new/eslint-plugin-qwik@7283

npm i https://pkg.pr.new/create-qwik@7283

commit: 46861fc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 46861fc

gioboa
gioboa reviewed Jan 30, 2025
View reviewed changes
scripts/binding-platform.ts Outdated Show resolved Hide resolved
@gioboa gioboa disabled auto-merge January 30, 2025 11:16
gioboa
gioboa previously approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @wmertens

@wmertens wmertens enabled auto-merge (squash) January 30, 2025 11:19
@wmertens wmertens merged commit da69196 into main Jan 30, 2025
21 checks passed
@wmertens wmertens deleted the fix-optimizer-copy branch January 30, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmertens @gioboa