Bugfix: working filter by header value #134
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When on a test, I noticed that the "Header doesn't contain" filter didn't work. It turned out that
message_passed_interception_filters
inauthorization.py
used a wrong index to get the filter value:I've fixed this using an approach where you don't have to hard-code the index. Now we split by
:
at the start of the function to getinterceptionFilterTitle
andinterceptionFilterContent
and cut off the extra space symbol after the filter name.As a bonus, I've also changed
auth_enforced_via_enforcement_detectors
to use the same approach. I've also expanded the filter list to distinguish between request and response headers. Here are the new filter names:I hope this will be of use to the others. Please let me know if this needs any changes