Skip to content

Conversation

supersaiyansubtlety
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety commented Sep 23, 2025

  • extracts QuickFindToolBar from QuickFindDialog
  • disables automatic QuickFindDialog creation when SyntaxpainConfiguration has null dialog factory
  • eliminates initComponents() because it could lead to unexpected behavior due to it being called from the constructor
  • eliminates translate() as translation was not supported and subclasses can implement their own translation

Supersede #4.
Facilitates QuiltMC/enigma#304 superseding #5

Can be manually tested by publishing locally, then on QuiltMC/enigma#304 running :enigma-swing:completeTestGui.

disable automatic QuickFindDialog creation when SyntaxpainConfiguration has null dialog factory
…s may implement their own translation

inline initComponents because re-calling it or overriding it and trying to access instance fields could lead to unexpected behavior; users should put the contents of their overrides in their constructors
add QuickFindToolBar::dismissOnFocusLost, allowing subclasses to control whether the toolbar is dismissed when it loses focus
remove escape-to-close keybind from QuickFindToolBar; users may add their own keybinds
@supersaiyansubtlety supersaiyansubtlety marked this pull request as ready for review September 23, 2025 19:52
@supersaiyansubtlety
Copy link
Member Author

ready

This was referenced Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant