-
Notifications
You must be signed in to change notification settings - Fork 1
[BAK-51] [기능]AIChatTab 특정 탭 메시지 가져오기 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nahyeongjin1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
페이지네이션을 도입한다면 created_at만 인덱스로 설정하거나 chat_tab_id와 같이 복합 인덱스로 설정하는게 좋을 것 같습니다.
수고하셨습니다!
| cursor.execute( | ||
| "SELECT * FROM chat_message WHERE chat_tab_id = ? ORDER BY created_at ASC", | ||
| (id,), | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(chat_tab_id, created_at)으로 복합 인덱스를 생성하면 이 부분에 아래와 같은 페이지네이션 관련 변경이 생길 때 탐색과 정렬 작업이 사라져 성능 향상을 기대할 수 있을 것 같습니다.
...
WHERE chat_tab_id = ? ORDER BY created_at ASC LIMIT 20 OFFSET 40There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
의견 감사합니다. 해당 부분은 사용자 질의 기능 개발에서 반영하겠습니다.
JIRA Task 🔖
참고 사항
black .ruff format .으로 인한 코드 포맷이 있습니다.