Skip to content

Conversation

@nahyeongjin1
Copy link
Member

@nahyeongjin1 nahyeongjin1 self-assigned this Aug 4, 2025
@apaals2
Copy link
Contributor

apaals2 commented Aug 5, 2025

오 코드, 흐름, 훔쳐가겠습니다.

@nahyeongjin1 nahyeongjin1 force-pushed the feature/save-api-key branch from 0e99654 to 4fb428a Compare August 5, 2025 13:55
Copy link
Contributor

@ChoiSeungWoo98 ChoiSeungWoo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업은 비슷하게 됐을 거 같아서 일단 하나의 PR에만 리뷰 남기겠습니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

각 기능별 코드 번호는 빠르게 회의 후 맞추면 좋을 거 같습니다!

@nahyeongjin1 nahyeongjin1 force-pushed the feature/save-api-key branch from 26afb3f to f69b4a2 Compare August 7, 2025 01:53
@nahyeongjin1 nahyeongjin1 force-pushed the feature/save-api-key branch 2 times, most recently from bd4f07b to 00c03f8 Compare August 7, 2025 02:31
@nahyeongjin1 nahyeongjin1 force-pushed the feature/save-api-key branch from 00c03f8 to 492ab25 Compare August 7, 2025 02:31
Copy link
Contributor

@ChoiSeungWoo98 ChoiSeungWoo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 확인 부탁드립니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

값 유효성 검사는 어제 어노테이션이 아닌 직접 메서드 만들어서 관리하자고 되었던 거 같은데 확인 부탁드립니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete 브랜치 쪽에서 일괄적으로 하려고 했었는데 일단 pr 열려있는 브랜치에 다 변경을 해둘까요?

@apaals2
Copy link
Contributor

apaals2 commented Aug 7, 2025

수고하셨습니다 ~ !!
아자아자! 화이팅!!

@nahyeongjin1
Copy link
Member Author

nahyeongjin1 commented Aug 7, 2025

credential 이라는 단어가 들어간 변수명을 수정하는 작업은 #40 에 진행했습니다.

@apaals2 apaals2 merged commit 7fdb844 into develop Aug 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants