Integrate modified scheduler to reversible-transfers pallet#15
Integrate modified scheduler to reversible-transfers pallet#15
scheduler to reversible-transfers pallet#15Conversation
dastansam
force-pushed
the
feat/explicit-reverser
branch
from
3586218 to
cd4bd93
Compare
dastansam
changed the title
|
Overall looks good, I'm impressed you got that abstraction BlockNumberOrTimestamp to work...I'm a bit concerned about these TODOs and the fact that the scheduler can fail to schedule things. |
czareko
left a comment
czareko
left a comment
There was a problem hiding this comment.
@dastansam , I can't build your branch
error[E0046]: not all trait items implemented, missing:Moment, TimeProvider, TimestampBucketSize--> /Users/cezaryo/quantus/github/backbone/runtime/src/configs/mod.rs:267:1 | 267 | impl pallet_scheduler::Config for Runtime { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missingMoment, TimeProvider, TimestampBucketSizein implementation | = help: implement the missing item:type Moment = /* Type /;= help: implement the missing item:type TimeProvider = / Type /;= help: implement the missing item:type TimestampBucketSize = / Type */;`
For more information about this error, try rustc --explain E0046.
error: could not compile resonance-runtime (lib) due to 1 previous error
`
…backbone into feat/clone-scheduler
dastansam
changed the title
scheduler to reversible-transfers pallet
dastansam
force-pushed
the
feat/clone-scheduler
branch
from
941b3d4 to
e6b1c60
Compare
…to clone-scheduler
…backbone into scheduler-logic
…backbone into feat/clone-scheduler
dastansam
force-pushed
the
feat/clone-scheduler
branch
from
a1cfdbb to
de0bb9b
Compare
…to feat/clone-scheduler
| type Hasher: Hash; | ||
|
|
||
| /// Schedule a task with a name, dispatch time, and optional periodicity. | ||
| fn schedule_named( |
There was a problem hiding this comment.
having periodic is quite fancy. I guess they will consume more and more fees?
Do they take fees from the sender every time they execute? I guess they would have to?
I mean I know that's in the OG scheduler already just wondering how it works.
There was a problem hiding this comment.
Do they take fees from the sender every time they execute? I guess they would have to?
yes they do. but it keeps retrying if the last dispatch fails due to low fees. once the max retries are exhausted it won't do anything
|
LGTM, just needs the conflicts resolved (new checkins I am sure) |
4 participants
Code is ready for review, I am working on the tests, benchmarks fixes
For reviewers: first commit contains the scheduler pallet forked as is, and other commits are granular changes to the logic and enhancements