Feature: exclude architectures #240
Conversation
There was a problem hiding this comment.
LGTM!
Just a quick note: Have you thought about adding a test for merge-architecture? If it isn’t already covered.
Also, while exclude? is tested in core, it might be useful to create a unit test for variant/exclude? as well. This can serve as a practical example in addition to the docstring.
These are critical fns, so I'm a bit more nit picky.
|
I'm still working on this. I dove into spec-based generative testing, but I think I'm going to crawl back out of that rabbit hole for one of the fns I started implementing it for. I will have some generative testing coming up though. :) |
|
I'm going to try to wrap this up soon. Sorry it has lingered so long! |
|
I'm making progress on this again. It required getting the test.chuck library running under Babashka, which required changes to Babashka itself, the instaparse pod, and test.chuck (😅) but I now have it generating test inputs from regexes. Getting these generators right was really giving me trouble, but test.chuck's Additional commits coming soon! |
This is in anticipation of adding some clojure.spec-based generative tests, which the official test runner doesn't support well.
cap10morgan
force-pushed
the
feature/exclude-architectures
branch
from
5621a2f to
7773c83
Compare
|
OK @Quantisan at long last this should be good to re-review 🎉 |
|
Once this lands we'll start publishing arm64 alpine variants for Java 21+! |
|
Thanks! I’m on the road. Will be back at work MondayOn Apr 24, 2025, at 2:18, Wes Morgan ***@***.***> wrote:
cap10morgan left a comment (Quantisan/docker-clojure#240)
Once this lands we'll start publishing arm64 alpine variants for Java 21+!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
#238 revealed a blind spot in the exclusion code: architectures. This PR refactors & reorganizes some code and fixes that. It replaces the
config/distro-architecturessubsystem with the more generalized exclusion mechanism.The only slightly tricky part is that for our variant generation & exclusion code, it makes sense to have a separate variant for each architecture. However, when we generate the manifest file (that tells the Docker Official Image folks what images to build from which dirs in this repo), we need to combine variants that only vary by architecture. So that's what this PR does.
Fixes #238