Fix: install curl explicitly in tools-deps images #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and use it instead of wget since the tools-deps installer script needs that anyway. An upstream mistake removed curl from some eclipse-temurin images, so this makes sure it’s installed either way.
See code comment for why
|
@Quantisan I'll go ahead and merge this to unblock our official-images PR, but let me know if you have any review feedback and I can address in a follow-up PR. |
tianon
reviewed
Apr 10, 2024
| @@ -36,7 +38,7 @@ | |||
| "RUN \\"] | |||
| (concat-commands install-dep-cmds) | |||
| (concat-commands | |||
| ["wget https://download.clojure.org/install/linux-install-$CLOJURE_VERSION.sh" | |||
| ["curl -sLO https://download.clojure.org/install/linux-install-$CLOJURE_VERSION.sh" | |||
There was a problem hiding this comment.
To make my notes from docker-library/official-images#16579 (comment) more concrete, in case it's helpful: ❤️
Suggested change
| ["curl -sLO https://download.clojure.org/install/linux-install-$CLOJURE_VERSION.sh" | |
| ["curl -fsSLO https://download.clojure.org/install/linux-install-$CLOJURE_VERSION.sh" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and use it instead of wget to save on installing that since the tools-deps install script needs curl anyway.
Some upstream images inadvertently removed curl causing this build error: https://github.com/docker-library/official-images/actions/runs/8633451962/job/23666676411?pr=16579
This ensures that curl is installed either way.