feat: add splice on HugrGraph ADT #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 99a7416.
3 tasks
croyzor
reviewed
Jan 14, 2026
| splice hole add non_root_k = modify $ \host -> case (M.lookup hole (nodes host) >>= isHole) of | ||
| Just (_, sig) -> case M.lookup (root add) (nodes add) of | ||
| Just (OpDFG (DFG sig' _)) | sig == sig' -> {-inlineDFG hole-} host { | ||
| -- prefer host entry for parent of (`hole` == root of `add`) |
Collaborator
There was a problem hiding this comment.
This comment implies M.union, but below it's actually union
Collaborator
There was a problem hiding this comment.
and I think it should be disjoint union
croyzor
reviewed
Jan 14, 2026
| splice :: forall m n. (Ord n, Ord m) => n -> HugrGraph m -> (m -> n) -> State (HugrGraph n) () | ||
| splice hole add non_root_k = modify $ \host -> case (M.lookup hole (nodes host) >>= isHole) of | ||
| Just (_, sig) -> case M.lookup (root add) (nodes add) of | ||
| Just (OpDFG (DFG sig' _)) | sig == sig' -> {-inlineDFG hole-} host { |
Collaborator
There was a problem hiding this comment.
Suggested change
| Just (OpDFG (DFG sig' _)) | sig == sig' -> {-inlineDFG hole-} host { | |
| Just (OpDFG (DFG sig' _)) | sig == sig' -> host { |
croyzor
reviewed
Jan 14, 2026
| host_out = execState (splice hole add (keyMap M.!)) host | ||
| in (host_out, ns_out) | ||
|
|
||
| inlineDFG :: Ord n => n -> State (HugrGraph n) () |
Collaborator
There was a problem hiding this comment.
Do we need inlineDFG or is it vestigial from an earlier implementation of splice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the HugrGraph ADT added in #97.
splicereplaces a HoleOp (ignoring the index) with a DFG-rooted Hugr of matching signature, i.e. inserts the DFG.inlineDFGflattens the result, if desired. However, it'd be better to combine them - see comment.I wasn't sure what the best approach was for dealing with new/old keys, but the
splicemethod is general over both key types by taking a translation function, which gives some guarantee that we are translating the keys.splice_prepend(both NodeID Hugr's) andsplice_new(arbitrary-keyed into NodeID) offer two possibilities....take a look and see what you think?My hope ATM is that we don't need to deal with order edges since these are only added for nonlocal edges, and so we can do splicing/inlining before adding order edges.
Tests are pretty basic (i.e. about the simplest possible case, with/without inline). These should be more thorough....