-
Notifications
You must be signed in to change notification settings - Fork 44
Blog Post: NumPy Benchmarking #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @khushi-411 ! I did an initial pass and the overall structure looks good to me. I left a number of comments (some about formatting, others about sentence structure and rewording) that I hope you can take into consideration. Please let me know if something is not clear, and please ping me if you want me to have another look later. Thanks!
Hi @melissawm, |
Could you reformat the text to fit (as much as possible) into 80 columns for easier review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran Grammarly on the post and found a couple more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few small comments, otherwise looks fine to me. Thanks @melissawm for the editing suggestions.
Could you use the latest graph (normalized by |
to set expectations, we are tentatively planning to publish this post on 10/26. please repsond with any issues or concerns. |
Sure, thanks a lot @tonyfast! |
@khushi-411 this is quite impressive work. thank you for writing about your experience. i really <3 the calligraphy. a few thoughts:
@mattip @melissawm maybe y'all could have a last look as we ready this for publishing. |
WoWtastic, I'm so happy to hear your thoughts, @tonyfast. Indeed, it was the best learning experience. Thank you so much to the team! ❤️ |
i'm going to merge this based on the feedback i've gotten. all changes from here on will be added errata. |
Text styling
Non-text contents
This blog post is a quick overview of my experience as an intern at Quansight. I'd like to know your inputs.
Thanks!