Skip to content
This repository was archived by the owner on Mar 6, 2023. It is now read-only.

Blog Post: NumPy Benchmarking #260

Merged
merged 7 commits into from
Nov 3, 2021
Merged

Conversation

khushi-411
Copy link
Contributor

@khushi-411 khushi-411 commented Sep 26, 2021

Text styling

  • The blog is written with plain language (where relevant).
  • If there are headers, they use the proper header tags in order to do so (with only one level-one header).
  • All links describe where they link to (for example, check the Quansight labs website).
  • Any kind of styling that the author uses (for example, bold for emphasis) is consistent throughout the blog.

Non-text contents

  • All content is represented as text (for example, images need alt text and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing gifs or videos.
  • If it were to be read as plain text, the blog still makes sense and no information is missing.

This blog post is a quick overview of my experience as an intern at Quansight. I'd like to know your inputs.
Thanks!

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @khushi-411 ! I did an initial pass and the overall structure looks good to me. I left a number of comments (some about formatting, others about sentence structure and rewording) that I hope you can take into consideration. Please let me know if something is not clear, and please ping me if you want me to have another look later. Thanks!

@khushi-411
Copy link
Contributor Author

Hi @melissawm,
Thank you so much for all the detailed reviews. I made corrections according to my understanding. Let me know if I can add or subtract anything else. Thanks!

@mattip
Copy link
Contributor

mattip commented Sep 29, 2021

Could you reformat the text to fit (as much as possible) into 80 columns for easier review?

@khushi-411 khushi-411 requested a review from mattip September 29, 2021 15:43
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran Grammarly on the post and found a couple more details.

Copy link
Contributor

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few small comments, otherwise looks fine to me. Thanks @melissawm for the editing suggestions.

@mattip
Copy link
Contributor

mattip commented Oct 1, 2021

Could you use the latest graph (normalized by n_particles ** 2), I think it is more interesting.

@tonyfast
Copy link
Contributor

to set expectations, we are tentatively planning to publish this post on 10/26. please repsond with any issues or concerns.

@khushi-411
Copy link
Contributor Author

Sure, thanks a lot @tonyfast!

@tonyfast
Copy link
Contributor

@khushi-411 this is quite impressive work. thank you for writing about your experience. i really <3 the calligraphy. a few thoughts:

  • the list formats work well
  • your visuals are great
  • its really impressive the technologies you covered.
  • i think there is a lot of value in your advice for beginners, i'd kind of like to see that moved up in the narrative, and highlight you'll be providing that advice.
  • it reads like you truly did have a great experience.

@mattip @melissawm maybe y'all could have a last look as we ready this for publishing.

@khushi-411
Copy link
Contributor Author

WoWtastic, I'm so happy to hear your thoughts, @tonyfast. Indeed, it was the best learning experience. Thank you so much to the team! ❤️

@tonyfast
Copy link
Contributor

tonyfast commented Nov 3, 2021

i'm going to merge this based on the feedback i've gotten. all changes from here on will be added errata.

@tonyfast tonyfast merged commit 673d1b3 into Quansight-Labs:main Nov 3, 2021
@khushi-411 khushi-411 deleted the khushi_blog branch February 6, 2022 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants