PCVL-1235 Added more logs - #26
Merged
Merged
Conversation
Benoit-F-Q
reviewed
Apr 24, 2026
| self._job.cancel() | ||
| raise RuntimeError("Job has been canceled.") | ||
| except: | ||
| except Exception as e: |
Collaborator
There was a problem hiding this comment.
Il y a confusion des genres entre exception & code d'erreur.
L'exception sert à transmettre ce genre d'info (job failed), l'exception est peut-être plus importante que l'échec du job, etc ...
| raise | ||
| try: | ||
| self._job.cancel() | ||
| finally: |
Collaborator
There was a problem hiding this comment.
Si job.cancel() raise, on perd la deuxième exception
Benoit-F-Q
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.