-
Notifications
You must be signed in to change notification settings - Fork 193
One-off build for rustworkx
sdist and retworkx
#1494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stable/0.17
Are you sure you want to change the base?
Conversation
@@ -42,7 +42,7 @@ | |||
long_description_content_type="text/markdown", | |||
author=pyproject["project"]["authors"][0]["name"], | |||
author_email=pyproject["project"]["authors"][0]["email"], | |||
license=pyproject["project"]["license"], | |||
license="Apache-2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory this is deprecated, but so is retworkx
so I think it will be fine
Pull Request Test Coverage Report for Build 17584542303Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should move the sdist creation to using python -m build --sdist
for rustworkx.
When I test this locally it's able to build the sdist without errors like the CI job had.
The build isolation from build
probably won't work for retworkx because that's a bit more special but that's ok.
branches: | ||
- 'stable/0.17' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should undo this change, we don't want to forget about this. After this PR merges we can trigger the wheel build with a throwaway branch that we do as a one shot branched off of stable/0.17's HEAD. We'll also need to relax the release protection to enable triggering from a branch but we can do that in a one off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an if
condition to check that the date is today, does that work?
@mtreinish I updated rustworkx's command to be For the one-off branch: I don't want to create yet another branch. Maybe we can reuse |
@mtreinish I tested that the content of this PR is uploadable: rustworkz. I had to change https://test.pypi.org/project/retworkx/0.17.1/ also worked. I think we can merge this just to unblock users that opt for |
Related to #1492
I tested this locally and it worked e.g.
python setup.py sdist
passes.For
retworkx
, it had more to do with thedist
being in the wrong path