Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replace old fake v2 backends with new fake v2 backends #7967

Closed
wants to merge 11 commits into from
Closed

[WIP] Replace old fake v2 backends with new fake v2 backends #7967

wants to merge 11 commits into from

Conversation

HuangJunye
Copy link
Collaborator

@HuangJunye HuangJunye commented Apr 20, 2022

Summary

There were older fake BackendV2 classes that were created before for testing. We need to rename, reorganize or remove those classes. See #7838 for details.

This is a work in progress

  • FakeBackendV2
  • FakeBackendV2LegacyQubitProps
  • FakeBackend5QV2
  • FakeBackendSimple
  • Release note

Details and comments

Fixes #7838

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@HuangJunye HuangJunye marked this pull request as draft April 20, 2022 14:30
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FakeBackend5QV2 is not equivalent to manila in this case. The FakeBackend5QV2 class is designed to provde different combinations of a heterogeneous gate set on a device (where different qubits have different gates defined on them). Primarily to test where different 2q links have different gates available. Most of the tests which are using it are specifically testing that the transpiler is functioning correctly when the backend target is this way. None of the ibm devices are configured this way so there is not an available alternative to this custom class

@HuangJunye
Copy link
Collaborator Author

@mtreinish I see. Let think about how to better deal with the FakeBackend5QV2 class. I think at the minimum we should add a better docstring and rename it to explain the purpose.

Meanwhile I reverted the changes related to this class and try to fix other errors. Do we need the test_run_circuit_oracle_single_experiment_backend test for V2 backends?

https://github.com/Qiskit/qiskit-terra/blob/dde6126e8d8ad550801e9a29adc21c83faf17748/test/python/algorithms/test_backendv2.py#L84-L96

I see these lines were copied from test_backendv1.py (#7563) and those were in turn introduced in #6391. Does V2 backend has max_experiment attribute?

@HuangJunye
Copy link
Collaborator Author

Closing staled PR

@HuangJunye HuangJunye closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename old fake BackendV2 classes
3 participants