-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Replace old fake v2 backends with new fake v2 backends #7967
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FakeBackend5QV2
is not equivalent to manila in this case. The FakeBackend5QV2
class is designed to provde different combinations of a heterogeneous gate set on a device (where different qubits have different gates defined on them). Primarily to test where different 2q links have different gates available. Most of the tests which are using it are specifically testing that the transpiler is functioning correctly when the backend target is this way. None of the ibm devices are configured this way so there is not an available alternative to this custom class
@mtreinish I see. Let think about how to better deal with the Meanwhile I reverted the changes related to this class and try to fix other errors. Do we need the I see these lines were copied from |
Closing staled PR |
Summary
There were older fake BackendV2 classes that were created before for testing. We need to rename, reorganize or remove those classes. See #7838 for details.
This is a work in progress
Details and comments
Fixes #7838