Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It appears that
GILOnceCell
is not sufficient for module import and initialization. When running free-threaded Python in unit tests, CPython throws a_DeadLockError
during module import. Even thoughGILOnceCell
allows threads to race and the first one to finish gets the initialization, it appears that the import process itself is not reentrant.Details and comments
This may also require a bug report on PyO3, since its implementation of
GILOnceCell::import
does what we were doing previously.This issue was discovered by @raynelfss when using Rust PyO3 tests on Linux.