Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of BackendProperties (BackendV1) in UnitarySynthesis pass #13706

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Jan 21, 2025

Summary

This PR includes:

  • Test upgrade -> Upgrade of class unit tests to avoid use of Backend V1. Some tests were also modified to use target instead of basis_gates, as the functionality they were testing was dependant of the backend_props input (deprecated)
  • Removal -> Removed the backend_props argument from UnitarySynthesis, as it relied on the deprecated BackendProperties class. The argument itself was never deprecated, so it might be necessary to open a deprecation PR against 1.4.

Note that this PR touches on code that is currently actively worked on in:

And there will be conflicts.

Details and comments

@ElePT ElePT added the Changelog: Removal Include in the Removed section of the changelog label Jan 21, 2025
@ElePT ElePT added this to the 2.0.0 milestone Jan 21, 2025
@coveralls
Copy link

coveralls commented Jan 21, 2025

Pull Request Test Coverage Report for Build 12890078963

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 21 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.009%) to 88.946%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 93.33%
crates/qasm2/src/lex.rs 4 91.98%
crates/qasm2/src/parse.rs 6 97.15%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 10 56.17%
Totals Coverage Status
Change from base Build 12888875366: 0.009%
Covered Lines: 79404
Relevant Lines: 89272

💛 - Coveralls

@ElePT ElePT marked this pull request as ready for review January 21, 2025 15:20
@ElePT ElePT requested review from alexanderivrii, ShellyGarion and a team as code owners January 21, 2025 15:20
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@ElePT
Copy link
Contributor Author

ElePT commented Jan 21, 2025

Marked as on hold to make sure I have a 1.4 deprecation ready before merging this PR.

@ElePT
Copy link
Contributor Author

ElePT commented Jan 22, 2025

No longer on hold after #13719

@ElePT ElePT removed the on hold Can not fix yet label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants