Deprecate extensions on stable/0.46 #11498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
Changelog: Deprecation
|
One or more of the the following people are requested to review this:
|
jakelishman
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Thanks for this. The biggest comment is that 0.46 shouldn't contain any new removals (it's a warning-only release), and most of the ones that have been effected here are were only deprecated in 0.45, so they wouldn't have been valid for removal anyway.
edit: I didn't highlight every removal in the review, but all of them need reverting.
releasenotes/notes/deprecate-extensions-046-2b98dce6fdfadc72.yaml
Outdated
Show resolved
Hide resolved
... that still need one more release for removal
|
I reverted the eager removals in a31325a 🙂 |
Cryoris
removed
the
Changelog: Removal
jakelishman
previously approved these changes
Jan 8, 2024
ElePT
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecation analogue of #11488 for the
stable/0.46branch.