[executor-preview] Tests for validation of NLV3 #2496
+129
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaelbh
changed the title
Collaborator
Author
|
Ready for review. Note that the PR contains a bug fix. |
yaelbh
changed the title
SamFerracin
reviewed
Dec 7, 2025
Collaborator
SamFerracin
left a comment
SamFerracin
left a comment
There was a problem hiding this comment.
Thanks! A couple of small comments
Comment on lines
33
to
45
| configuration = BackendConfiguration( | ||
| backend_name="im_a_backend", | ||
| backend_version="0.0", | ||
| n_qubits=1e100, | ||
| basis_gates=["rx"], | ||
| gates=[], | ||
| local=False, | ||
| simulator=False, | ||
| conditional=True, | ||
| open_pulse=False, | ||
| memory=True, | ||
| coupling_map=[], | ||
| ) |
Collaborator
There was a problem hiding this comment.
Why not passing FakeAlgiers.configuration()?
| with self.assertRaisesRegex(ValueError, "xslow"): | ||
| validate_options(options=options, configuration=configuration) | ||
|
|
||
| def test_validate_instruction(self): |
Collaborator
There was a problem hiding this comment.
This is a big test function with many assert. In general, I prefer breaking big test functions into many smaller test functions with asserts targeting a single concern, for example:
test_validate_instruction_passes_when_options_validtest_validate_instruction_without_twirl_raisestest_validate_instruction_without_box_raises- ...
The benefit is that if we make a change that invalidate one of these asserts, we immediately get a hint of what caused the break by reading the name(s) of the broken tests, as opposed to having to dig through
Collaborator
Author
There was a problem hiding this comment.
Please check the solution of using subTest (2340427).
Co-authored-by: Samuele Ferracin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2479.
Tests for the function in the file
qiskit_ibm_runtime/noise_learner_v3/validation.Details and comments