-
Notifications
You must be signed in to change notification settings - Fork 192
Remove RuntimeOptions
#2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove RuntimeOptions
#2301
Conversation
ElePT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another deprecation slip-up from the runtime programs era. This should have been deprecated when it stopped being useful server-side. At this point, I again see this cleanup as a bugfix rather than a new deprecation, given that the functionality stopped working a long time ago. I am fine with the removal, I would just point out the release note to document it.
ElePT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have found a downstream package that depended on RuntimeOptions. Given that we are in no rush to remove the class, I suggest turning this PR into a deprecation PR instead of a removal. I would keep the typehint changes though, they reflect the current status better.
|
Since we just deprecated |
Summary
Draft PR for now, still need to test which options actually work. Currently more of a POC to show that we don't need the
RuntimeOptionsclass anymore and it's confusing to have this extra "options" class.Details and comments
Fixes #2300