Make 'rainbowGenerating' state persistent across restarts#40
Open
GeneSerano wants to merge 1 commit intoQelifern:4.3.2from
Open
Make 'rainbowGenerating' state persistent across restarts#40GeneSerano wants to merge 1 commit intoQelifern:4.3.2from
GeneSerano wants to merge 1 commit intoQelifern:4.3.2from
Conversation
…e was being loaded but not used or saved into a value.
Author
|
Broke once after this so thought it might not have been a full fix, but must have been a one off glitch or issue caused by another mod because after days of intensive testing repeatedly doing things that were a guaranteed break before and there have been no further issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue were RainbowGen state is "broken" on server restart as value was being saved and then loaded but not used or saved into the appropriate variable on load. Only way to fix was to break all the other furnaces and re-set everything up, with the variable being stored correctly the state is maintained on restart (as it was saved, but never used so always defaulted to false on restart) and switches on and off appropriately if the other furnaces stop/start meeting the correct conditions. Would have messaged you on discord as you asked but you don't have it linked anywhere.