You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes the client error of the "qbx_core:server:getVehiclesToSpawn" callback not existing if the "qbx:vehiclePersistenceType" convar is not set to "full"
Checklist
I have personally loaded this code into an updated Qbox project and checked all of its functionality.
My pull request fits the contribution guidelines & code conventions.
I'm not sure I see the benefit of registering the OnPlayerLoaded and removeVehZone event handlers if the persistence convar isn't set to full. Is there a specific reason they need to be registered even when they won't execute any logic?
I'm not sure I see the benefit of registering the OnPlayerLoaded and removeVehZone event handlers if the persistence convar isn't set to full. Is there a specific reason they need to be registered even when they won't execute any logic?
That makes sense. I had not fully analyzed the logic, yet. But now looking at it, you are right. The last two functions are unneeded, if the server is not in full mode. Just looks a bit "odd" to me, with the guard clause sitting out on its lonesome. Haha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the client error of the "qbx_core:server:getVehiclesToSpawn" callback not existing if the "qbx:vehiclePersistenceType" convar is not set to "full"
Checklist