Repository navigation
Add D4/F4 S3 orbit and covariant equivariance harness - #17
Conversation
There was a problem hiding this comment.
Sorry @EmergentMonk, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 2 hours and 16 minutes by commenting @sourcery-ai review. Upgrade to get a review now.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer's GuideThis PR makes the D4/F4-to-modular S3 symmetry layer executable: it constructs and cross-checks both quotient actions, derives coefficient transformations from exact binary-form substitution, and proves 90 exact symbolic equivariance identities for the 15 covariants, with canonical commitments, tests, verification commands, and documentation; it introduces no sonification behavior. Sequence diagram for exact covariant equivariance verificationsequenceDiagram
participant Harness
participant Modular as Modular quotient
participant Forms as Binary forms
participant Basis as 15 covariants
participant Exact as Exact polynomial engine
Harness->>Modular: buildModularS3QuotientRepresentatives()
loop six representatives
Harness->>Forms: deriveCoefficientAction(matrix)
Forms->>Exact: substituteUv(f, matrix)
Forms->>Exact: substituteUv(g, matrix)
loop 15 covariants
Harness->>Basis: select covariant polynomial
Harness->>Exact: substituteCoefficientVariables(polynomial, substitutions)
Harness->>Exact: substituteUv(polynomial, matrix)
Exact-->>Harness: polynomialsEqual(left, right)
end
end
Harness-->>Harness: 90 exact checks passed
Flow diagram for the D4/F4 and modular quotient cross-checkflowchart TD
SEED[Seed: 2,4,6,10]
GENERATORS[Generate e, S, T, ST, TS, STS]
RELATIONS[Verify S^2 = I, T^2 = I, and ST^3 = I]
ORBIT[Construct six-point D4 orbit]
MODULAR[Construct canonical modular representatives]
REDUCE[Reduce representatives modulo 2]
TABLES[Compute both multiplication tables]
MATCH{Tables match exactly?}
PASS[Symmetry contract passes]
SEED --> GENERATORS
GENERATORS --> RELATIONS
GENERATORS --> ORBIT
GENERATORS --> MODULAR
MODULAR --> REDUCE
ORBIT --> TABLES
REDUCE --> TABLES
TABLES --> MATCH
MATCH -->|yes| PASS
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Implements the second locked D4-TIA research phase as D4-TIA-S3-EQUIV v0.1.0.
PR #16 made the 15 published binary covariants executable. This PR makes the symmetry layer executable and verifies that the exact covariants transform equivariantly before any new sonification mapping is designed.
This phase adds no MIDI mapping, tuning, tempo, timbre, PCM, rendered audio, ETQ-101 change, or ETQ-303 change.
Exact D4/F4 triality quotient
Using the Sakai-aligned matrices already frozen in the repository, the harness constructs the six exact elements generated by
w_S,w_T:and verifies exactly:
The fixed D4 seed
(2,4,6,10)has a deterministic six-element orbit, pinned in the canonical fixture.Modular quotient side
The harness uses canonical
SL2(Z)representatives generated fromand reduces them modulo 2 to identify the six classes of
The D4/F4 multiplication table and the modular quotient multiplication table are independently computed and required to agree exactly.
A critical boundary is explicit throughout the implementation: the six modular matrices are representatives of quotient classes. The PR does not assert that they form a literal six-element subgroup of
SL2(Z)upstairs.Coefficient action is derived, not copied
For each modular representative
the transformed coefficients are derived directly by expanding
inside the exact sparse-rational polynomial engine from PR #16.
There is no second manually maintained transformation table.
Exact covariant equivariance
For every one of the 15 exact covariants and every one of the six canonical representatives, the harness independently constructs both sides of
and compares the resulting exact sparse polynomials term-for-term.
That gives:
No floating-point tolerance, random sampling, numerical fitting, or perceptual proxy is involved.
Canonical identity
Adds:
examples/d4-tia-s3-equivariance.v0.1.canonical.jsonspec/d4-tia-s3-equivariance.v0.1.schema.jsonThe fixture pins the exact D4 orbit, modular quotient representatives, quotient multiplication table, coefficient-action hashes, and transformed-basis hashes. The schema binds the complete summary with
const.Implementation
Added:
src/d4-triality-s3-equivariance.mjstests/d4-triality-s3-equivariance.test.mjsscripts/verify-d4-tia-s3-equivariance.mjsdocs/D4_TRIALITY_S3_EQUIVARIANCE.mdnpm run verifynow validates D4-TIA-COV, D4-TIA-S3-EQUIV, D4-TIA-15, and the existing ETQ v3/v2/v1 chain.Roadmap
This phase is now marked implemented. The remaining locked sequence is:
The next phase may finally define a new receiver, but it must be downstream of this tested symmetry contract.
Validation
The branch has passed the complete repository CI matrix, including:
npm test;npm run verify;Summary by Sourcery
Implement the D4-TIA-S3-EQUIV symmetry harness and establish an exact, canonical equivariance contract for the 15 binary covariants.
New Features:
Enhancements:
Documentation:
Tests:
Chores: