Repository navigation
Add D4-TIA-15 triality-invariant algebra sonification profile - #15
Conversation
There was a problem hiding this comment.
Sorry @EmergentMonk, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 3 hours and 22 minutes by commenting @sourcery-ai review. Upgrade to get a review now.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer's GuideThis PR adds D4-TIA-15 v1.0.0 as an independently versioned, validation-heavy symbolic sonification profile over the existing 15-generator D4 ledger, producing committed JSON/CSV/MIDI artifacts with direct receiver mappings, fail-closed builds, provenance hashes, verification, tests, and documentation while leaving ETQ identities and root audio policy unchanged. Flow diagram for D4-TIA-15 profile generation and verificationflowchart LR
Ledger[D4 triality reference ledger] --> Profile[buildGeneratorEvents]
Profile --> Checks[Validate grading relations and MIDI ranges]
Checks --> Document[Build canonical contract and event document]
Document --> Artifacts[Build JSON CSV and symbolic MIDI artifacts]
Artifacts --> Manifest[Create SHA-256 manifest and source identity]
Manifest --> Verify[verify-d4-tia.mjs]
Flow diagram for D4-TIA-15 receiver projectionflowchart LR
Generator[Published generator order] --> Sequence[Event sequence]
Grades[Published grading ledger] --> Onset[m to onset tick]
Grades --> Duration[d to duration ticks]
Grades --> Note[k to MIDI note]
Grades --> Channel[omega to MIDI channel]
Refined[da and db] --> Metadata[Preserved event metadata]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d1fa2822a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34335fc09d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Implements the roadmap's separately versioned triality-invariant algebra sonification profile as D4-TIA-15 v1.0.0.
The source object is the published 15-generator minimal basis already recorded in
src/d4-triality-reference.mjs. This PR does not modify ETQ-101 v2 or ETQ-303 v3 protocol identity.Published grading preserved
Every event carries the published grading data:
d_a,d_b;d = d_a + d_b;m;k; andomega.Generation fails if any row violates:
v1 receiver mapping
To avoid inventing rescalings or fitted latent quantities, v1 uses direct identity transfers:
These assignments are explicitly documented as authored receiver conventions. The mathematics does not assert that modular weight is acoustic pitch or that covariant order is MIDI channel.
Velocity is a fixed receiver constant (64). MIDI division is 1. No tempo meta event is emitted. Acoustic tuning, timbre, loudness, and wall-clock tempo are external and non-normative.
Artifacts
npm run build:d4-tiawrites only root-policy-allowed artifacts:contract.jsonevents.jsonevents.csvevents.midmanifest.jsonThe MIDI file uses one metadata track plus 15 generator tracks so generator identity remains explicit even where MIDI projections collide.
The manifest records SHA-256 artifact commitments and a source-bundle implementation identity.
Versioning and verification
Added:
src/d4-triality-algebra-profile.mjssrc/d4-triality-algebra-artifacts.mjsspec/d4-tia-15.v1.schema.jsonexamples/d4-tia-15.v1.canonical.jsonscripts/build-d4-tia-artifacts.mjsscripts/verify-d4-tia.mjstests/d4-triality-algebra-profile.test.mjsdocs/D4_TRIALITY_ALGEBRA_SONIFICATION.mdnpm run verifynow verifies D4-TIA-15 before the existing v3/v2/v1 chain.Claim boundary
D4-TIA-15 is a deterministic symbolic sonification profile over a published invariant/covariant generator ledger. It does not claim that:
Root PCM/rendered audio remains permanently disabled.
Summary by Sourcery
Implement the separately versioned D4-TIA-15 symbolic sonification profile without changing ETQ protocol identities.
New Features:
Enhancements:
Build:
Documentation:
Tests: