Repository navigation
feat: historical Melbourne Cup archive back to 1861, including Empire Rose 1988 - #2
Conversation
…and documentation
|
Sorry @EmergentMonk, you've used your own review budget of 250,000 diff characters for the last 7 days. You can request another review in 1 day and 2 hours by commenting |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer's GuideThe PR extends the deterministic historical archive from three years to 11 spanning 1861–2025, models partial historical evidence honestly as TOP 3 exhibits, adds complete 1988 and 2005 orders, and wires coverage-aware selection, UI messaging, receipt provenance, engine safeguards, documentation, and regression tests without changing the legacy 2023–25 simulation models. Sequence diagram for partial-field replay protectionsequenceDiagram
actor User
participant UI as Replay UI
participant Engine as Race engine
participant Archive as ARCHIVE
User->>UI: Select podium archive year
UI->>Archive: getArchive(year)
Archive-->>UI: coverage podium and fieldSize
UI->>UI: Disable what-if option
User->>Engine: buildRace(mode, year)
Engine->>Archive: getArchive(year)
Archive-->>Engine: podium archive
alt mode is whatif
Engine-->>User: RangeError: What-if requires a complete recorded field
else mode is replay
Engine-->>UI: Fixed top-three replay with synthetic motion
end
Entity relationship diagram for historical archive provenanceerDiagram
ARCHIVE_RECORD {
number year PK
string coverage
number fieldSize
number recordedRunners
string source
string secondarySource
}
REPLAY_RECEIPT {
number year
string coverage
number fieldSize
number recordedRunners
boolean syntheticMotion
}
ARCHIVE_RECORD ||--o{ REPLAY_RECEIPT : produces
Flow diagram for dynamic archive selection and replay displayflowchart TD
Start[Load application] --> Populate[Populate archive selector from ARCHIVE]
Populate --> Select[Select year]
Select --> Coverage{Archive coverage}
Coverage -->|full| Full[Show FULL marker and recorded runners]
Coverage -->|podium| Top3[Show TOP 3 marker and historical field size]
Full --> Mode[Configure replay or what-if]
Top3 --> Replay[Force replay mode]
Mode --> Run[Build deterministic race]
Replay --> Run
Run --> Receipt[Export coverage and field-size provenance]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Historical preservation release
Adds eight racing-history exhibits to the existing three-year MELBCUPSIM archive (11 total years, 1861–2025).
Complete finishing orders: 1988 Empire Rose (22 runners); 2005 Makybe Diva (24 runners).
Sourced podium showcases: 1861 Archer (17 historical starters), 1930 Phar Lap (15), 1983 Kiwi (24), 1987 Kensei (21), 1989 Tawrrific (23), 1990 Kingston Rule (24). Only the verified first three are depicted; other competitors are deliberately not fictionalised.
Implementation: dynamic archive selection, visible FULL/TOP 3 markers, historical field-size provenance in exported receipts, engine rejection of what-if simulations based on incomplete fields, and regression tests. Existing 2023–25 models untouched.
Research honesty: 1988 complete ordering comes from a published 22-place secondary table; VRC independently corroborates first/second but full source reconciliation remains an open archival task. See README for all evidence links and limitations. The 3200m oval is still a schematic animated exhibit, not original race telemetry or period track geometry.
No gambling mechanics, dependencies or external runtime services.
Summary by Sourcery
Extend the simulator's historical Melbourne Cup archive back to 1861 while preserving provenance and preventing unsupported simulations of incomplete historical fields.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests: