Skip to content

PR for G2RT into main branch#67

Merged
yalinli2 merged 56 commits into
QSD-Group:mainfrom
zixuan-w:toilet
Jul 7, 2026
Merged

PR for G2RT into main branch#67
yalinli2 merged 56 commits into
QSD-Group:mainfrom
zixuan-w:toilet

Conversation

@zixuan-w

Copy link
Copy Markdown
Member

Please see the test function below. Please let me know if you need help with anything! Thanks.

def test_g2rt():
    from numpy.testing import assert_allclose
    from exposan import g2rt

    rtol = 0.01
    
    modelA = g2rt.create_model('A')
    dfA = modelA.metrics_at_baseline()
    valuesA = [534.561, 1.34665, 396.737]
    assert_allclose(dfA.values, valuesA, rtol=rtol)
    
    modelB = g2rt.create_model('B')
    dfB = modelB.metrics_at_baseline()
    valuesB = [754.523, 1.66349, 470.437]
    assert_allclose(dfB.values, valuesB, rtol=rtol)

@zixuan-w zixuan-w requested a review from yalinli2 June 10, 2026 18:16

@yalinli2 yalinli2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, as long as QSDsan's side is good, we can merge this in.

@yalinli2

yalinli2 commented Jul 7, 2026

Copy link
Copy Markdown
Member

The failed test was due to the changes in SludgePasteurization, leading to different results in reclaimer.SysA, I've opened a new issue related to this. I'll fix the metric when that is done. Good to merge in the g2rt systems.

@yalinli2 yalinli2 merged commit cb836a5 into QSD-Group:main Jul 7, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants