Skip to content

Commit

Permalink
Upgraded from a now-rather-old verison of jQuery to v2.1.4 which migh…
Browse files Browse the repository at this point in the history
…t fix some performance issues in newer versions of Firefox (still have to test that more). The upgrade required changing .live() to .off()/.on().
  • Loading branch information
unknown authored and unknown committed Dec 21, 2015
1 parent 053439f commit 000d771
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 10 deletions.
4 changes: 0 additions & 4 deletions jquery-1.7.1.min.js

This file was deleted.

4 changes: 4 additions & 0 deletions jquery-2.1.4.min.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions manifest.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "Scrum for Trello",
"version": "1.94",
"version": "1.96",
"description": "Adds Scrum to your Trello",
"content_scripts": [
{
"matches": ["https://trello.com/*"],
"js": ["jquery-1.7.1.min.js","trelloscrum.js"],
"js": ["jquery-2.1.4.min.js","trelloscrum.js"],
"css": ["trelloscrum.css"]
}
],
Expand Down
11 changes: 7 additions & 4 deletions trelloscrum.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,12 @@ $(function(){
function updateFilters() {
setTimeout(calcListPoints);
};
$('.js-toggle-label-filter, .js-select-member, .js-due-filter, .js-clear-all').live('mouseup', calcListPoints);
$('.js-input').live('keyup', calcListPoints);
$('.js-share').live('mouseup',function(){
$('.js-toggle-label-filter, .js-select-member, .js-due-filter, .js-clear-all').off('mouseup');
$('.js-toggle-label-filter, .js-select-member, .js-due-filter, .js-clear-all').on('mouseup', calcListPoints);
$('.js-input').off('keyup');
$('.js-input').on('keyup', calcListPoints);
$('.js-share').off('mouseup');
$('.js-share').on('mouseup',function(){
setTimeout(checkExport,500)
});

Expand All @@ -137,7 +140,7 @@ var recalcListAndTotal = debounce(function($el){
}, 500, false);

var recalcTotalsObserver = new CrossBrowser.MutationObserver(function(mutations)
{
{
// Determine if the mutation event included an ACTUAL change to the list rather than
// a modification caused by this extension making an update to points, etc. (prevents
// infinite recursion).
Expand Down

1 comment on commit 000d771

@SeanColombo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was me. Sorry no email was set in my gitconfig.

Please sign in to comment.