CI / Guthub actions v2 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ADD github actions v2
Frank1234
requested review from
ninovanhooff,
sebaslogen and
Techwolf12
and removed request for
sebaslogen,
Techwolf12 and
ninovanhooff
Frank1234
requested review from
ninovanhooff,
sebaslogen and
Techwolf12
and removed request for
ninovanhooff
Techwolf12
previously approved these changes
Jul 31, 2024
#68) ADD CI firebase upload ADD CI unittests
ninovanhooff
previously approved these changes
Aug 9, 2024
|
|
||
| - First create your own keystore and store it in 1pw. _You do not add this keystore to the repo_ ( | ||
| like we did in this template as an example). | ||
| - add a KEYSTORE_BASE_64 [new github repository secret](./settings/secrets/actions/new) that is the |
There was a problem hiding this comment.
After merging this PR, please trigger ask dependabot build by choosing any open dependabot PR and reacting with @dependabot recreate
If that fails, the changes you made in the secrets need to be reflected into the dependabot secrets; and that should be documented here
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this important?
We had a two-headed CI setup, partly fastlane, partly github actions. It increased complexity * 2. Also, signing key usage was not included, we've added it here.
In this ticket
devDebugapk and aprodDebugapk buildprodReleasebundle andprodReleaseapk)Example actions that ran because of this PR: