Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builds and metadata tooling #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AbstractUmbra
Copy link
Collaborator

Description

Update the repository and build stages to use PDM over Poetry. This allows for sleeker builds as well as multi-stage docker image support (resulting in a smaller final image).

Also move the usage of .env to use docker secrets instead. Env variables can leak into the final image, and can be read by consumers.
This doesn't apply to use due to the final image being untouchable outside of deployment staff, but it's best to follow best practices.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

@AbstractUmbra AbstractUmbra self-assigned this Dec 27, 2024
@AbstractUmbra AbstractUmbra marked this pull request as ready for review December 28, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant