Fix issue during the parsing of "badbins" #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects the behaviour which was added to parse content from "badbins", the likes of pastebin and hastebin and send them to mystb.in.
The problem is that previous iterations of mystbin returns a "notice" field in the response, we used to use that to notice the pasting user of their notice. This is no longer the case.
The code was previously updated to account for this, but further in the
on_message
listener we attempt to unpack the return of the function which previously returned atuple[str, str]
, but now only returnsstr
.Pyright did not catch this, believing that
foo, bar = "baz"
to be valid in this case, which it was not.This corrects that, as well as bad code smells.
EDIT: Our
ruff
action isn't version bound, so I've had to update, run and correct code around ruff. I can split this into a separate PR if necessary.Checklist