Skip to content

[WIP] Nystrom sinkhorn #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

tvayer
Copy link
Collaborator

@tvayer tvayer commented Jul 8, 2025

Types of changes

Objective: implement the method in "Massively scalable Sinkhorn distances via the Nyström method, Jason Altschuler, Francis Bach, Alessandro Rudi, Jonathan Niles-Weed, NeurIPS 2019.
So far: added low_rank_kernel for Sinkhorn, Nystrom kernel for Nystrom Sinkhorn, empirical_sinkhorn_nystroem
Also

TODO

  • Add loss for empirical_sinkhorn_nystroem
  • Add documentation
  • Add tests for empirical_sinkhorn_nystroem
  • Add tests for kernel approximation using Nystrom
  • Put in the API ot.solve ?
  • Add example
  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • Update readme with refs
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 33 lines in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (99477be) to head (1bae4b9).

❗ There is a different number of reports uploaded between BASE (99477be) and HEAD (1bae4b9). Click for more details.

HEAD has 19 uploads less than BASE
Flag BASE (99477be) HEAD (1bae4b9)
20 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #742       +/-   ##
===========================================
- Coverage   97.09%   85.23%   -11.87%     
===========================================
  Files         100      100               
  Lines       20432    20579      +147     
===========================================
- Hits        19839    17541     -2298     
- Misses        593     3038     +2445     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant