-
Notifications
You must be signed in to change notification settings - Fork 516
[WIP] Wrappers for OT barycenter solvers #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cedricvincentcuaz
wants to merge
10
commits into
PythonOT:master
Choose a base branch
from
cedricvincentcuaz:solvers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #730 +/- ##
===========================================
- Coverage 97.09% 85.27% -11.82%
===========================================
Files 100 100
Lines 20432 20644 +212
===========================================
- Hits 19839 17605 -2234
- Misses 593 3039 +2446 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
ot.utils.BaryResult
extendingOTResult
first draft for OT barycenter solvers with samples and predefined metric
ot.solvers.bary_sample
built on top ofot.solvers.solve_sample
extending significantly available OT losses for the barycenter problem.learn_X=True
andlearn_b=False
equivalent to free support POT solvers using BCD with closed form. Only metrics in ('sqeuclidean', 'euclidean') are support for now. The solver calls an hidden function_bary_sample_bcd
.update_masses
inot.solvers._bary_sample_bcd
.warmstart
tobary_sample
, and based on the requested inner solver, we pick the adequate strategywarmstart_plan
orwarmstart_potentials
passed to_bary_sample_bcd
.stopping_criterion
in ('loss', 'bary') passed to_bary_sample_bcd
.learn_X=True
andlearn_b=True
learn_X=False
andlearn_b=True
should be solved via futureot.solvers.bary
after computing built-in cost matrices.ot.solve_sample
Motivation and context / Related issue
test.test_solvers.assert_allclose_bary_sol
method to compare solutions asBaryResult
objects.test_bary_sample
grid across all available barycenter solvers depending on those available inot.solvers.solve_sample
.How has this been tested (if it applies)
PR checklist