Modified _parse_gdx_results in GAMS.py to replace _parse_special_value and Updated Import Statement #3642
+40
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsiirola
reviewed
Jun 24, 2025
Comment on lines
42
to
43
| from pyomo.common.dependencies import attempt_import | ||
| import numpy as np |
There was a problem hiding this comment.
This adds a hard dependency on numpy. Importing numpy from dependencies will keep this as a "soft" dependency:
Suggested change
| from pyomo.common.dependencies import attempt_import | |
| import numpy as np | |
| from pyomo.common.dependencies import attempt_import, numpy as np |
It will still make numpy a hard dependency if you are going to use GAMS, but that is OK (although GAMS's available() should probably check both numpy_available and gdxcc_available)
…Removed the unused _parse_special_values function
jsiirola
reviewed
Jun 26, 2025
| specVals[gdxcc.GMS_SVIDX_UNDEF] = float("nan") | ||
| specVals[gdxcc.GMS_SVIDX_PINF] = float("inf") | ||
| specVals[gdxcc.GMS_SVIDX_MINF] = float("-inf") | ||
| specVals[gdxcc.GMS_SVIDX_NA] = struct.unpack(">d", bytes.fromhex("fffffffffffffffe"))[0] |
There was a problem hiding this comment.
Why is this not just float('nan')?
| @@ -1299,7 +1324,7 @@ def _parse_gdx_results(self, results_filename, statresults_filename): | |||
| raise RuntimeError("GAMS GDX failure (gdxDataReadRaw).") | |||
|
|
|||
| if stat in ('OBJEST', 'OBJVAL', 'ETSOLVE'): | |||
| stat_vars[stat] = self._parse_special_values(ret[2][0]) | |||
There was a problem hiding this comment.
Does this mean we can also remove / delete the _parse_special_values method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3624
Summary/Motivation:
When parsing the results of a model after it has been solved, the level and dual value are obtained through a series of
ifstatements in_parse_special_valuesthat may cause slowdowns. This PR added GAMS existing functions to handle data parser for these special values in_parse_gdx_results.Changes proposed in this PR:
_parse_special_valueswith GAMS special value parser in_parse_gdx_results.attempt_importto have fallback to pre-GAMS-45.0 API ifgams.core.gdxis not available.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: