-
Notifications
You must be signed in to change notification settings - Fork 545
Update tabular_writer to include option to not sort rows #3578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@avdudchenko - Oop, can you please undo your last commit? You used |
Done. |
Thinking about this PR, I am wondering if we should remove the sorting from
|
One additional thought: this would break backwards compatibility for the generated ostream, but not functional compatibility. This change could impact tests that rely on diffing those strings. |
I honestly think keeping backwards compatibility is better, especially if we are concerned about tests. |
Fixes # .
tabular_writer forces sorting on the user provided Rows even when user might not desire such sorting to occur, this adds an option to disable sorting
Summary/Motivation:
I want to be in control of my table order.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: