Renderer.checkbox uses the checked keyword param #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, Renderer.checkbox("name", checked=True) will ignore the checked keyword param and always pass False to the tags.checkbox method, even if there is no value available for "name". This change allows users to request the renderer to default checked to True, while still reflecting changes when data is available.
This behavior (allowing a renderer default) matches that of several existing methods, including textarea, text, and password.
|
I believe this is also the problem referenced in issue #3. |
|
+1 ! |
|
Ups, just found out this PR, after submitting #17 (sorry!). Maybe you can still get some use for the tests I've added there. |
|
Thank you for the pull request. I merged #17 which included tests but has the same effect as this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
Renderer.checkbox("name", checked=True)will ignore thecheckedkeyword param and always passFalseto thetags.checkboxmethod, even if there is no value available for"name". This change allows users to request the renderer to defaultcheckedtoTrue, while still reflecting changes when data is available.This behavior (allowing a renderer default) matches that of several existing methods, including
textarea,text, andpassword.