refactor!: ConnectionState & Event Handling #5
Conversation
definitely doesn't work yet, just felt like there was way too much changes not to commit already
large part left is the ConnectionState itself since events haven't been transformed yet
I need to make more commits
Co-authored-by: Paillat <[email protected]> Signed-off-by: VincentRPS <[email protected]>
|
@VincentRPS You should also import defaultdict |
|
Any news ? See traceback of another error here: https://canary.discord.com/channels/881207955029110855/881735314987708456/1373639761696133160 |
|
Congrats @VincentRPS you successfully broke the docs ! 🎉 |
Co-authored-by: Paillat <[email protected]> Signed-off-by: VincentRPS <[email protected]>
|
@VincentRPS I am going to rebase this for you and push here |
M'kay! |
Paillat-dev
changed the title
…guild_role_update, guild_role_delete
| ) | ||
| return | ||
|
|
||
| member = await guild.get_member(int(data["user"]["id"])) |
There was a problem hiding this comment.
Normally people aren't members of guilds that they're being unbanned from
| return await self.cache.get_all_stickers() | ||
|
|
||
| async def get_emoji(self, emoji_id: int | None) -> GuildEmoji | AppEmoji | None: | ||
| return await self.get_emoji(emoji_id) |
There was a problem hiding this comment.
| return await self.get_emoji(emoji_id) | |
| return await self.cache.get_emoji(emoji_id) |
| await state.maybe_store_app_emoji(state.application_id, e) | ||
|
|
||
|
|
||
| class GuildCreate(Event, Guild): |
There was a problem hiding this comment.
this (among a few other events) appears to be duplicated in guild.py?
| else: | ||
| self.dispatch("guild_join", guild) | ||
|
|
||
| def parse_guild_audit_log_entry_create(self, data) -> None: |
There was a problem hiding this comment.
I assume these leftover parse functions have yet to be converted into events?
|
@VincentRPS are you still working on this ? |
6 participants
definitely doesn't work yet