Skip to content

fix: pass RUSTFLAGS #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: pass RUSTFLAGS #462

wants to merge 2 commits into from

Conversation

n-bes
Copy link

@n-bes n-bes commented Aug 24, 2024 •
edited
Loading

Custom RUSTFLAGS passed only when internal RUSTFLAGS is set, fixed it. Possibly fix pypa/pip#12935

@n-bes
Copy link
Author

n-bes commented Aug 24, 2024 •
edited
Loading

Oh, it is already copied... So, something another is wrong.

setuptools-rust/setuptools_rust/build.py

Line 625 in f42ae5b

env = os.environ.copy()

davidhewitt
davidhewitt reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I'm not sure I understand the motivation for the patch, nor what the functional change is from the patch submitted. Could you please elaborate?

@n-bes n-bes closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pass rustflags to isolated environemnt
2 participants
@n-bes @davidhewitt