Skip to content

ci: move main build to use test-rust nox job #5091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

davidhewitt
Copy link
Member

As a precursor to investigating #5080, I wanted to make the test workflow in CI more similar to what I can run locally.

This modifies the noxfile's test-rust job to be much closer to build.yml semantics, and then changes build.yml to call it.

@davidhewitt davidhewitt added CI-build-full CI-no-fail-fast If one job fails, allow the rest to keep testing labels Apr 25, 2025
@davidhewitt
Copy link
Member Author

Hmm, @bschoenmaeckers got any idea what the jiff failure might be caused by?

  ---- src/conversions/jiff.rs - conversions::jiff (line 22) stdout ----
  Test executable failed (exit status: 1).
  
  stderr:
  Error: PyErr { type: <class 'ValueError'>, value: ValueError('cannot convert non-fixed IANA time zone to offset without timestamp or civil datetime'), traceback: None }
  
  
  
  failures:
      src/conversions/jiff.rs - conversions::jiff (line 22)

(PyPy and GraalPy failures are unrelated, I'll look into those separately.)

@bschoenmaeckers
Copy link
Member

This is maybe related to #5055.

I disabled the zoneinfo branch on pre python 3.9. It looks like it tries to convert a non-fixed timezone to a fixed timezone which fails. Before this it would throw a import error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-build-full CI-no-fail-fast If one job fails, allow the rest to keep testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants