Implement OnceExt & MutexExt for parking_lot & lock_api
#5044
Conversation
bschoenmaeckers
force-pushed
the
lockext_parking_lot
branch
3 times, most recently
from
39cba21 to
3e76d58
Compare
bschoenmaeckers
force-pushed
the
lockext_parking_lot
branch
from
3e76d58 to
f17fd0f
Compare
bschoenmaeckers
force-pushed
the
lockext_parking_lot
branch
from
90c1c34 to
bede7b5
Compare
|
In my first implementation I used associated types (generic over some lifetime) for the return value of |
|
Can we get a mention in this docs section that we also have |
| @@ -0,0 +1 @@ | |||
| Implement `OnceExt` & `MutexExt` for `parking_lot` & `lock_api` | |||
There was a problem hiding this comment.
You should also mention the new features IMO
| @@ -1047,6 +1132,51 @@ mod tests { | |||
| }); | |||
| } | |||
|
|
|||
| #[cfg(feature = "macros")] | |||
| #[cfg(all(feature = "parking_lot", not(target_arch = "wasm32")))] // We are building wasm Python with pthreads disabled | |||
| #[test] | |||
There was a problem hiding this comment.
Can we get a test for the lock_api feature too?
There was a problem hiding this comment.
I don't think so. The lock_api crate does not provide actual locks, only the traits. So we need parking_lot to test it.
There was a problem hiding this comment.
But can't we turn on both features and write a test that uses e.g. lock_api::RawMutex::lock_once_py_attached?
There was a problem hiding this comment.
Do you mean lock_api::Mutex::<parking_lot::RawMutex, _>::lock_py_attached?
There was a problem hiding this comment.
Sorry for speaking imprecisely - I'm not very familiar with parking_lot. I actually didn't realize until now that lock_api is provided by parking_lot.
What I'm trying to understand is why it's not possible to write a test that enables both features and uses the functionality provided by the lock_api feature. When I asked before, you explained that the reason is because lock_api only provides traits. I'm trying to say that, at least from my point of view, that doesn't prevent writing a test that uses a parking_lot mutex and turns on the lock_api feature. Can you explain where I'm misunderstanding things?
Co-authored-by: Nathan Goldbaum <[email protected]>
ref #5038