Convert PathBuf & Path into python pathlib.Path instead of PyString
#4925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoenmaeckers
force-pushed
the
pathbuf-pathlib
branch
3 times, most recently
from
7a4cd73 to
5adfc6c
Compare
bschoenmaeckers
force-pushed
the
pathbuf-pathlib
branch
from
5adfc6c to
fc26584
Compare
|
How do we handle paths that are not utf-8? I believe both Rust and Python have ways to represent these, but I think especially on the Rust side, this is considered an implementation detail and I'm not sure we can safely convert between them. |
|
Not a full review (yet), but I think we need to keep the current behavior for the deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4907