git precommit configuration (#310)

Author: rickwierenga

.pre-commit-config.yaml

@@ -1,18 +1,10 @@
 repos:
-  - repo: local
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.2.1
     hooks:
-      - id: check fix
-        name: check fix
-        entry: python -m ruff check --fix pylabrobot --select I
-        language: system
-        pass_filenames: false
-      - id: format
-        name: format
-        entry: python -m ruff format pylabrobot
-        language: system
-        pass_filenames: false
-      - id: run-typecheck
-        name: Run typecheck
-        entry: python -m mypy pylabrobot --check-untyped-defs
-        language: system
-        pass_filenames: false
+      - id: ruff
+        args: [ --fix, --select, I ]
+        files: ^pylabrobot/.*$
+      - id: ruff-format
+        files: ^pylabrobot/.*$
+

docs/conf.py

@@ -172,4 +172,3 @@
   suppress_warnings = ["toc.excluded"]
 
 html_favicon = "_static/favicon.ico"
-

tools/make_lc.py

@@ -84,9 +84,7 @@ def main():
       continue
 
     dat = binascii.unhexlify(curve_data[2:])
-    assert len(dat) % 16 == 0 and not len(dat) == 0, (
-      "invalid length for " + dat.decode()
-    )
+    assert len(dat) % 16 == 0 and not len(dat) == 0, "invalid length for " + dat.decode()
 
     curve: Dict[float, float] = {}
 
@@ -100,13 +98,12 @@ def main():
     if notes != "":
       notes = "\n    # " + "\n    # ".join(notes.splitlines())
 
-    if name[0] in {
-      str(i) for i in range(11)
-    }:  # python doesn't allow numbers as first character
+    if name[0] in {str(i) for i in range(11)}:  # python doesn't allow numbers as first character
       name = "_" + name
 
     out_file.write(
-      textwrap.dedent(f"""\n
+      textwrap.dedent(
+        f"""\n
     {notes}
     mapping[({tip_volume}, {core}, {tip}, {has_filter}, Liquid.{liquid.name}, {jet}, {empty})] = \\
     {name} = HamiltonLiquidClass(
@@ -128,7 +125,8 @@ def main():
       dispense_settling_time={dispense_settling_time},
       dispense_stop_flow_rate={dispense_stop_flow_rate},
       dispense_stop_back_volume={dispense_stop_back_volume}
-    )""")
+    )"""
+      )
     )
 
     print(name)

tools/make_resources/make_ham_resources.py

@@ -1,7 +1,5 @@
 def main():
-  raise NotImplementedError(
-    "This script is deprecated. Use the new resource definitions."
-  )
+  raise NotImplementedError("This script is deprecated. Use the new resource definitions.")
 
 
 if __name__ == "__main__":

tools/make_resources/ot/make.py

@@ -21,7 +21,6 @@
 
 
 def main(po, to, tro):
-
   p = os.path.join(OT_PATH, "labware", "definitions", "2")
   p = os.path.expanduser(p)
 
@@ -35,9 +34,7 @@ def main(po, to, tro):
 
         try:
           # we don't really care about name
-          resource = load_shared_opentrons_resource(
-            definition, version=version, name=file
-          )
+          resource = load_shared_opentrons_resource(definition, version=version, name=file)
         except UnknownResourceType:
           print(f"[SKIP] {definition} {version}")
           continue

tools/make_resources/tc/make.py

@@ -1,4 +1,3 @@
-
 import re
 
 from pylabrobot.resources import Coordinate
@@ -78,9 +77,7 @@ def main(pc, tc, p, tr, tcr):
         if all(x == resource_size_x[0] for x in resource_size_x) and all(
           y == resource_size_y[0] for y in resource_size_y
         ):
-          o.write(
-            f"    sites=create_homogeneous_resources(klass=ResourceHolder, locations=[\n"
-          )
+          o.write(f"    sites=create_homogeneous_resources(klass=ResourceHolder, locations=[\n")
           for l in locations:
             o.write(f"        {repr(l)},\n")
           o.write(f"      ],\n")
@@ -174,9 +171,7 @@ def main(pc, tc, p, tr, tcr):
           o.write(f"  #   size_x={size_x},\n")
           o.write(f"  #   size_y={size_y},\n")
           o.write("  #   size_z=None,           # measure the total z height\n")
-          o.write(
-            "  #   nesting_z_height=None, # measure overlap between lid and plate\n"
-          )
+          o.write("  #   nesting_z_height=None, # measure overlap between lid and plate\n")
           o.write(f'  #   model="{lid_name}",\n')
           o.write("  # )\n\n\n")
 
@@ -226,9 +221,7 @@ def main(pc, tc, p, tr, tcr):
             # print a warning, because this parameter is confusing in the file and I don't have
             # have a device to test this on. tbc.
             tcr.write('  print("WARNING: total_tip_length <= 0.")\n')
-            tcr.write(
-              '  print("Please get in touch at https://discuss.pylabrobot.org")\n'
-            )
+            tcr.write('  print("Please get in touch at https://discuss.pylabrobot.org")\n')
           tcr.write(f"  return TecanTip(\n")
           tcr.write(f"    has_filter={has_filter},\n")
           tcr.write(f"    total_tip_length={total_tip_length},\n")
@@ -259,7 +252,7 @@ def main(pc, tc, p, tr, tcr):
 if __name__ == "__main__":
   with open("plate_carriers.py", "w") as plate_carriers, open(
     "tip_carriers.py", "w"
-  ) as tip_carriers, open("plates.py", "w") as plates, open(
-    "tip_racks.py", "w"
-  ) as tip_racks, open("tip_creators.py", "w") as tip_creators:
+  ) as tip_carriers, open("plates.py", "w") as plates, open("tip_racks.py", "w") as tip_racks, open(
+    "tip_creators.py", "w"
+  ) as tip_creators:
     main(plate_carriers, tip_carriers, plates, tip_racks, tip_creators)