Skip to content

fix: floating-point equality, unused param, duplicate calls, stdout safety, missing test#81

Merged
itsdakshjain merged 1 commit into
Py-Contributors:mainfrom
Xenon010101:fix/various-bugs
May 31, 2026
Merged

fix: floating-point equality, unused param, duplicate calls, stdout safety, missing test#81
itsdakshjain merged 1 commit into
Py-Contributors:mainfrom
Xenon010101:fix/various-bugs

Conversation

@Xenon010101

Copy link
Copy Markdown
Contributor

Summary

Fixed 6 bugs:

  1. is_one_one.py — Floating-point equality (== 1) fails on IEEE 754 rounding; use math.isclose
  2. is_one_one.py — Unused parameter Anik_one(a) immediately overwritten
  3. is_one_one.py — Duplicate function call (is_one_using_interdimensional_tax_fraud called twice instead of Anik_one)
  4. is_one_one.py — Same duplicate in main()
  5. test_core.py — Unsafe sys.stdout buffer reassignment (data loss risk on Windows)
  6. test_core.py — Missing test for Anik_one (added)

@github-actions

Copy link
Copy Markdown

✅ Logic Verified!

The Automated Logic Suite has confirmed that 1 is still 1.

  • Environment: Ubuntu-latest
  • Status: Mathematical Sanity Confirmed

You are safe to merge this chaos.

@itsdakshjain itsdakshjain left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contribution @Xenon010101 , if you are genuinely doing code cleanups, there are more you can do in these files...otherwise i willl merge it upon your response as it is

@itsdakshjain itsdakshjain left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you still working on it?or merge it at this stage only

@itsdakshjain

Copy link
Copy Markdown
Member

Hey can I know the reason for closing the pr ? @Xenon010101

@itsdakshjain itsdakshjain reopened this May 30, 2026
@github-actions

Copy link
Copy Markdown

✅ Logic Verified!

The Automated Logic Suite has confirmed that 1 is still 1.

  • Environment: Ubuntu-latest
  • Status: Mathematical Sanity Confirmed

You are safe to merge this chaos.

@Xenon010101

Copy link
Copy Markdown
Contributor Author

Hi @itsdakshjain, sorry for closing it — I was cleaning up old PRs and made a mistake. No further changes needed from my side; please go ahead and merge it as-is. Thanks!

@itsdakshjain itsdakshjain left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsdakshjain
itsdakshjain merged commit 4600cbf into Py-Contributors:main May 31, 2026
2 checks passed
@Xenon010101

Copy link
Copy Markdown
Contributor Author

Hi @itsdakshjain, could you please add the \gssoc\ and \gssoc:approved\ labels to this PR for GSSoC '26 scoring? Thanks!

@itsdakshjain

Copy link
Copy Markdown
Member

You should check gssoc project section on website for that . I have clearly mentioned in other issue too about it. This is a SANDBOX repo for learners and general open source contributors .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants