Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: on Chromium and Firefox, TaskAssigner dropdown shows up at top of screen #236

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

4xdk
Copy link
Collaborator

@4xdk 4xdk commented Aug 5, 2018

As per #161

@elimisteve
Copy link
Contributor

Please always check out develop first before creating a new branch, thanks 👍 .

@4xdk
Copy link
Collaborator Author

4xdk commented Aug 5, 2018

Did that . Maybe I didn't pull properly or something (git is still magic for me) .
Or do you mean that I commited to local develop instead of a branch?
Not sure what difference does it make ...
Any good git tutorials? 😉

Copy link
Contributor

@elimisteve elimisteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test it in all 3 browsers? See the bug before you made these enhancements?

@4xdk
Copy link
Collaborator Author

4xdk commented Aug 7, 2018

Despite behavior set as smooth (to check - e.g. Chrome, instant for Firefox), it always shows instantly (in those 3 browsers), so no as I can't replicate the issue.
I've just implemented your suggestion and trust it's what we need here:
Firefox needs behavior: 'smooth'
Chromium also needs behavior: 'smooth'
Chrome needs behavior: 'instant'

@4xdk
Copy link
Collaborator Author

4xdk commented Aug 8, 2018

@elimisteve if I could get some versions of chromium/firefox that have this issue I could try to replicate & confirm the fix.

@elimisteve
Copy link
Contributor

elimisteve commented Aug 8, 2018 via email

@4xdk
Copy link
Collaborator Author

4xdk commented Aug 8, 2018

No, I can't replicate it using newest versions of Chromium or Firefox.
It's this element, right? It appears instantly after clicking and looks correct.
screenshot_20180808_220858

@elimisteve
Copy link
Contributor

I should have said that I only have the issue when the dropdown is toward the bottom of the page, not at the top

@4xdk
Copy link
Collaborator Author

4xdk commented Aug 9, 2018

@elimisteve Still nothing different. Behaves the same as at the bottom? No issues either. What am I missing? I've checked the demo site and tried to break it on local ...
screenshot_20180809_073009

@elimisteve
Copy link
Contributor

Okay, don't worry about it :-) . You've done your part! I will mess with it, as I've had the issue on my browsers for months, so getting this fixed is huge :-D .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants