Local tripletriad newbind dev#211
Merged
Merged
Conversation
…so training may not match pufferbox. indeed, baseline did seem pretty shaky. baseline: https://wandb.ai/xinpw8/pufferlib/runs/m3frlbjf refactor: https://wandb.ai/xinpw8/pufferlib/runs/58ro6521 also, some offsets weren't adjusted when NOOP was removed (commit e39332b); i updated those as well. interestingly, it doesn't seem to really have improved training, however.
…ad.h was off-by-one; c perf test added + local eval updated
Contributor
|
Merged - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushed as-is. Removed \ from env_binding.h. No changes to any other env besides tripletriad. Conversion to new bindings only. Some issues with tripletriad still exist: e.g. env reaches terminal or errantly resets after only a few turns. Can debug in future.